Fix monitor hotplug #285
Merged
Fix monitor hotplug #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change doesn't delete outputs or CRT controllers when the screen configuration changes. Instead, the outputs are disconnected. This emulates the behaviour of other virtual X servers (e.e. tigervnc) and prevents X applications from encountering BadRROutput or BadRRCtrc errors.
The shared memory allocation has been reworked to make the monitor resizing codepaths easier to follow. This has resulted in one new input message, and one obsoleted one.
Makes sure the device is resized correctly when the monitor configuration is changed
Caller can set the fram ack value to INT_MAX to ack all frames. If this is done, we need to reset it after a capture to prevent the capture being overwritten while being copied.
On a GFX resize, clear the CRC areas to ensure that a full frame is transmitted when output restarts. Also, rename rdpClientSetSharedMemoryParameters() as rdpClientConResizeAllMemoryAreas() as this is more descriptive of what the routime is actually doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See neutrinolabs/xrdp#2942