Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a support system for proxy setting to download #255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moataz2002
Copy link

Description:

  • This pull request introduces proxy support for the neu create and neu update commands in the NeutralinoJS CLI tool. Proxy support enables users to create and update NeutralinoJS applications seamlessly while operating behind a proxy server.

Related Issues:

#198 -> "neu create fail behind a proxy"

Changes Made:

  • Added Proxy Support for neu create Command:

  • Modified the create command in commands/create.js to accept a proxy option (-p, --proxy [proxy]).
    Users can now specify a proxy URL when creating a new NeutralinoJS application.
    Added Proxy Support for neu update Command:

  • Modified the update command in commands/update.js to accept a proxy option (-p, --proxy [proxy]).
    Users can now specify a proxy URL when updating NeutralinoJS resources.
    Updated modules/downloader.js:

  • Modified the downloadBinariesFromRelease and downloadClientFromRelease functions to utilize proxy settings when downloading resources.

Updated Dependencies:

  • Added necessary dependencies (follow-redirects and decompress) to support proxy settings.

How to Test:

  • Ensure you have the latest version of the NeutralinoJS CLI tool installed.
    Create a new NeutralinoJS application using the neu create command with the -p or --proxy option, providing a valid proxy URL.
  • Update an existing NeutralinoJS application using the neu update command with the -p or --proxy option, providing a valid proxy URL.
  • Verify that the application is created or updated successfully, and the proxy settings are applied during resource download.

Additional Notes:

  • Proxy support enhances the usability of the NeutralinoJS CLI tool for users operating behind a proxy server.
  • This feature improves accessibility and ensures a seamless experience for developers working in restricted network environments.

Copy link
Member

@shalithasuranga shalithasuranga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @moataz2002. Thanks so much for sending this pull request. Could you please check whether it's possible to add this feature for neu update as well? 🎉

@moataz2002
Copy link
Author

Hello @shalithasuranga .. the feature is already added for neu update as well 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants