Don't create .bak files #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And simplify the write-out code with the help of itertools :) Love a good iterator
7 tasks
|
to be transparent, I haven't tested this yet. |
Drulex
reviewed
May 11, 2021
|
|
||
| with io.open(filename, 'w') as changelog: | ||
| for line in lines: | ||
| print(line, file=changelog) |
There was a problem hiding this comment.
Why use print() vs io.write()? It inserts extra linefeeds by default, which we don't want (probably need to use print(end="") or something.)
There are extra linefeeds in the changelog generated with this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And simplify the write-out code with the help of itertools :)
There's no need for this. We keep our code in git and that works way better.
Love a good iterator