forked from bids-standard/bids-specification
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft BEP031 #2
Open
mariehbourget
wants to merge
30
commits into
master
Choose a base branch
from
bep031_draft
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Draft BEP031 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcohenadad
reviewed
Sep 2, 2021
jcohenadad
reviewed
Sep 2, 2021
jcohenadad
reviewed
Sep 2, 2021
datatypes/microscopy.yaml
SampleSecondaryAntibody descriptions and examples.
numbers" to "two dimensional array of numbers"
Hi @jcohenadad, |
jcohenadad
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jcohenadad
This is a draft PR of BEP031 for review and approbation on our side only.
Once it is completed, I will open a PR on the main BIDS repo.
I recommend using mkdocs to see the rendered version of the doc.
The two files to review are:
src/04-modality-specific-files/10-microscopy.md
--> will appear underModality specific files/Microscopy
in the rendered doc.src/schema/entities.yaml
--> will appear underAppendix/Entities
in the rendered doc.Other files do not need review at this point.
In the final version (after community review), the tables and the file tree examples will be generated automatically via macros and specific yaml files. I was asked to do "manual" tables and examples to minimize the number of changed files and facilitate community review.
A few remaining points to address, details in comments in the
10-microscopy.md
file.Recommended participant data
section may changedmake_filetree
macro should be used before on only after community review.Note: I converted this PR from "draft" to "ready for review" only because I had problems pushing new commits to the branch when in "draft". Not sure why.