Modernize DECREF (part 3). #3206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3206 +/- ##
==========================================
+ Coverage 67.06% 67.07% +0.01%
==========================================
Files 569 569
Lines 111204 111200 -4
==========================================
+ Hits 74583 74592 +9
+ Misses 36621 36608 -13 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
|
✔️ 53f2384 -> Azure artifacts URL |
Documentation for PyObject_SetItem clearly states that it doesn't steal `pn`. The other call is undocumented.
1uc
force-pushed
the
1uc/modernize-decref-3
branch
from
53f2384
to
8d2a818
Compare
|
|
✔️ 8d2a818 -> Azure artifacts URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.