CoreNrn: support for rebalanced files.dat #3147
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3147 +/- ##
==========================================
- Coverage 67.06% 67.06% -0.01%
==========================================
Files 571 571
Lines 111319 111321 +2
==========================================
+ Hits 74658 74659 +1
- Misses 36661 36662 +1 ☔ View full report in Codecov by Sentry. |
|
✔️ d0f0cfe -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
ferdonline
changed the title
ferdonline
changed the title
ferdonline
force-pushed
the
leite/balanced_files2
branch
from
c72d108
to
d0f0cfe
Compare
ferdonline
force-pushed
the
leite/balanced_files2
branch
from
1d5fab0
to
005577e
Compare
|
|
✔️ 005577e -> Azure artifacts URL |
|
@ferdonline : I am converting this to a draft assuming this is specific to our custom manipulation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For MMB (BBPP134-917) we need to be able to load a set of .dat files distributed in given way.
However for the moment CoreNeuron only reads it in plain RoundRobin, which is not suitable to load ranks a different number of files.
This PR
We introduce a mark value (-1 in this case) indicating no-data so that, even with round-robin, we can define precisely which rank will load a given data file. All ranks will be able to jump strides of size N_RANKS (at their respective offset) and find entries targeted at them. Upon seeing a
-1the rank knows it is done and can stop reading.This is a minor addition which enabled us to load balance and run the MMB simulation