-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated python 3.8 #3108
Conversation
✔️ 4e2d2a4 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3108 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 569 569
Lines 111206 111206
=======================================
Hits 74592 74592
Misses 36614 36614 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
✔️ d006dec -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✔️ d818938 -> Azure artifacts URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.8 is officially EOL as of today, we can merge this.
Is there anything we're currently interested in that's failing only for Python 3.8? If not, I'd say continue to check until it breaks. |
Not sure if related, but CircleCI fails on 3.8: https://app.circleci.com/pipelines/github/neuronsimulator/nrn/9697/workflows/fabca25f-f7da-4e81-b0f3-bef12f3bf368/jobs/4732 I haven't found any mention of 3.8 being an issue on CircleCI, so it could just be a coincidence, but having one less Python version to support is always nice. |
Quality Gate passedIssues Measures |
✔️ f887ea2 -> Azure artifacts URL |
No description provided.