-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move random to src/gnu #2689
Move random to src/gnu #2689
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unable to retrieve AZURE drop url from comments! |
This comment has been minimized.
This comment has been minimized.
✔️ 7e94c47 -> Azure artifacts URL |
af3020e
to
1e9dce2
Compare
✔️ 756d18e -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
Quality Gate failedFailed conditions C Reliability Rating on New Code (required ≥ A) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2689 +/- ##
==========================================
- Coverage 66.32% 66.29% -0.04%
==========================================
Files 559 558 -1
Lines 108657 108431 -226
==========================================
- Hits 72071 71886 -185
+ Misses 36586 36545 -41 ☔ View full report in Codecov by Sentry. |
✔️ c57bbe4 -> Azure artifacts URL |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks @alkino !
This patch move most of the code that is not hoc to the directory gnu.
In the future this directory will be cleaned to remove gnu stuff and renamed something like 'src/random'.
This way nrn will have an external random library, and a clean hoc_interface.
This patch move
Isaac
,MCellRan4
,Random123
,Rand
.