Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run github workflows on merge queues #2568

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Run github workflows on merge queues #2568

merged 3 commits into from
Oct 5, 2023

Conversation

heerener
Copy link
Collaborator

@heerener heerener commented Oct 3, 2023 •
edited
Loading

Points of note:

  • The release workflow was left out of this because it was not configured to trigger on pull requests
  • The External CIs workflow was left out because it was configured to only run on labeled PRs. It will still trigger when you add a label to a PR, but should not be included in a merge queue.
  • The gitlab workflows don't have rules defined, so they will still follow their "always trigger" behavior.

@azure-pipelines
Copy link

✔️ 1552dcf -> Azure artifacts URL

@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

Merging #2568 (1552dcf) into master (0a3408f) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 1552dcf differs from pull request most recent head a50bbf9. Consider uploading reports for the commit a50bbf9 to get more accurate results

@@            Coverage Diff             @@
##           master    #2568      +/-   ##
==========================================
- Coverage   61.53%   61.49%   -0.04%     
==========================================
  Files         625      623       -2     
  Lines      119226   119196      -30     
==========================================
- Hits        73360    73296      -64     
- Misses      45866    45900      +34

see 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

Sign in to view
pramodk
pramodk approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no knowledge of merge queues but if you have tested this @heerener, we can go ahead with the merge.

ohm314
ohm314 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me - also thank you for cleanup the white spaces, that always bothers me whenever I stumble upon it.

@ohm314 ohm314 enabled auto-merge (squash) October 5, 2023 06:59
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@azure-pipelines
Copy link

✔️ a50bbf9 -> Azure artifacts URL

@ohm314 ohm314 merged commit c205e0a into master Oct 5, 2023
33 of 34 checks passed
@ohm314 ohm314 deleted the ci-triggers branch October 5, 2023 08:26
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #158629 (:white_check_mark:) have been uploaded here!

Status and direct links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodk pramodk pramodk approved these changes

@ohm314 ohm314 ohm314 approved these changes

Assignees
No one assigned
Labels
hackron2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heerener @bbpbuildbot @ohm314 @pramodk