Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rxd _evaluate function. #2561

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

adamjhn
Copy link
Member

@adamjhn adamjhn commented Sep 28, 2023

No description provided.

@adamjhn adamjhn added wip rxd reaction-diffusion labels Sep 28, 2023
@pramodk
Copy link
Member

pramodk commented Oct 12, 2023

Is this ready to merge? I could resolve conflict and push to your branch but maybe better if you do that in your fork? thanks!

@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 34 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 15 Security Hotspots
Code Smell A 800 Code Smells

No Coverage information No Coverage information
3.0% 3.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2561 (fd1d237) into master (9f59779) will increase coverage by 4.35%.
Report is 27 commits behind head on master.
The diff coverage is 52.04%.

@@            Coverage Diff             @@
##           master    #2561      +/-   ##
==========================================
+ Coverage   61.48%   65.84%   +4.35%     
==========================================
  Files         623      559      -64     
  Lines      119164   108968   -10196     
==========================================
- Hits        73266    71746    -1520     
+ Misses      45898    37222    -8676     
Files Coverage Δ
share/lib/python/neuron/rxd/generalizedReaction.py 77.27% <ø> (+3.33%) ⬆️
share/lib/python/neuron/rxd/rate.py 71.16% <66.66%> (+1.70%) ⬆️
share/lib/python/neuron/rxd/reaction.py 73.07% <50.00%> (-0.37%) ⬇️
share/lib/python/neuron/rxd/rxdmath.py 62.11% <89.65%> (+2.60%) ⬆️
.../lib/python/neuron/rxd/multiCompartmentReaction.py 82.55% <68.75%> (-1.01%) ⬇️
share/lib/python/neuron/rxd/species.py 77.41% <22.91%> (-1.85%) ⬇️

... and 157 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackron2023 rxd reaction-diffusion wip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants