Allow to run clang-format on nocmodl generated C++ files #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current master if we run clang-format on generated file
and try to rebuild then we get errors like
```
src/nrnoc/netstim.cpp:393:28: error: no member named '_prop' in 'Point_process'; did you mean 'prop'?
auto* const _p = _pnt->_prop;
```
This is because we have some magic header macros that rename certain
internal variables.
To avoid the issue, just tell clang-format to avoid sorting headers
included.
|
Alternatively, one could add newlines. AFAICT |
This comment has been minimized.
This comment has been minimized.
|
✔️ 3efad2e -> Azure artifacts URL |
|
@1uc : I can change it. But may be having this explicit is better? |
alkino
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current master if we run clang-format on the MOD file generated C++ file and try to rebuild the NEURON then we get errors like
This is because we have some magic header macros that rename certain internal variables.
To avoid the issue, just tell clang-format to avoid sorting these specific headers included.