Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use raw strings when substituting in paths from CMake. #2540

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

matz-e
Copy link
Collaborator

@matz-e matz-e commented Sep 26, 2023

This will silence a lot of warnings on Windows coming from using \ as a path separator. Should have no impact on systems posing as UNIX-compatible.

This will silence a lot of warnings on Windows coming from using \ as a
path separator.  Should have no impact on systems posing as
UNIX-compatible.
Copy link
Member

@alkino alkino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems more secure

@bbpbuildbot

This comment has been minimized.

@azure-pipelines
Copy link

✔️ f6a4a90 -> Azure artifacts URL

@azure-pipelines
Copy link

✔️ 85bb594 -> Azure artifacts URL

@nrnhines nrnhines merged commit 2c15679 into master Sep 27, 2023
30 of 31 checks passed
@nrnhines nrnhines deleted the fix-cmake-substitution branch September 27, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants