Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use char const * in oc_popen. #2532

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Use char const * in oc_popen. #2532

merged 3 commits into from
Sep 27, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Sep 25, 2023

This silences an warning related to oc_popen(..., "r").

@azure-pipelines
Copy link

✔️ 5a92341 -> Azure artifacts URL

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2532 (5a92341) into master (b4fdb4c) will decrease coverage by 0.01%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

❗ Current head 5a92341 differs from pull request most recent head 2364fa5. Consider uploading reports for the commit 2364fa5 to get more accurate results

@@            Coverage Diff             @@
##           master    #2532      +/-   ##
==========================================
- Coverage   61.48%   61.48%   -0.01%     
==========================================
  Files         623      623              
  Lines      119146   119152       +6     
==========================================
  Hits        73261    73261              
- Misses      45885    45891       +6     
Files Coverage Δ
src/oc/fileio.cpp 80.80% <ø> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

@azure-pipelines
Copy link

✔️ 5a92341 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@1uc 1uc marked this pull request as ready for review September 25, 2023 15:22
@ohm314 ohm314 merged commit ecb0999 into master Sep 27, 2023
4 of 13 checks passed
@1uc 1uc deleted the 1uc/fix-oc_popen branch September 3, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants