Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile sparse13 as its own static library #2451

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Conversation

alkino
Copy link
Member

@alkino alkino commented Aug 8, 2023

No description provided.

@nrnhines
Copy link
Member

nrnhines commented Aug 8, 2023

Just curious about the rationale. It all ends up in libnrniv anyway.

@alkino
Copy link
Member Author

alkino commented Aug 8, 2023

sparse 1.3 is only an external library: https://netlib.org/sparse/

I find it more clear to have separate builds for separate projects.

This way we are able to do clean build: make sparse13, and it forces us to not link nrniv and sparse13 together.

But if I'm alone, I can cancel this patch.

@azure-pipelines
Copy link

✔️ afb567d -> Azure artifacts URL

@alkino
Copy link
Member Author

alkino commented Aug 8, 2023

In fact I was planning to split everything in small independent parts:

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2451 (99bd14c) into master (138282b) will increase coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2451      +/-   ##
==========================================
+ Coverage   61.16%   61.48%   +0.32%     
==========================================
  Files         630      624       -6     
  Lines      121442   119173    -2269     
==========================================
- Hits        74277    73278     -999     
+ Misses      47165    45895    -1270     

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

@nrnhines
Copy link
Member

nrnhines commented Aug 8, 2023

Ok. I can see the value. I wrote sparse. I think there is some value in installing/distributing only libnrniv.
I expect libsundials.so will become an exception as it depends on mpi version. In analogy with libnrnmpi and libnrnpython
(although the need for the latter is ambiguous in the context of wheels since the python version on the user machine is known
by construction) there needs to be a corresponding libsundials_xxx.so to each libnrnmpi_xxx.so

@alkino
Copy link
Member Author

alkino commented Aug 8, 2023

To be clear, those libraries are still build statically, so at the end there is still a nrniv blob to deliver.

The difference is only on configuration and build.

@azure-pipelines
Copy link

✔️ d1c966b -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@azure-pipelines
Copy link

✔️ db948f1 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@azure-pipelines
Copy link

✔️ 7a8ba0a -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@azure-pipelines
Copy link

✔️ 701ccbb -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@github-actions
Copy link
Contributor

NEURON ModelDB CI: launching for 701ccbb via its drop url

@github-actions
Copy link
Contributor

NEURON ModelDB CI: 701ccbb -> download reports from here

@azure-pipelines
Copy link

✔️ 12aa1ed -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@azure-pipelines
Copy link

✔️ f7e5996 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@azure-pipelines
Copy link

✔️ 8a88b7c -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@azure-pipelines
Copy link

✔️ 99bd14c -> Azure artifacts URL

@pramodk pramodk merged commit 0110567 into master Sep 4, 2023
33 checks passed
@pramodk pramodk deleted the cornu/split_sparse13 branch September 4, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants