-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile sparse13 as its own static library #2451
Conversation
f463f0f
to
afb567d
Compare
Just curious about the rationale. It all ends up in libnrniv anyway. |
sparse 1.3 is only an external library: https://netlib.org/sparse/ I find it more clear to have separate builds for separate projects. This way we are able to do clean build: But if I'm alone, I can cancel this patch. |
✔️ afb567d -> Azure artifacts URL |
In fact I was planning to split everything in small independent parts:
|
Codecov Report
@@ Coverage Diff @@
## master #2451 +/- ##
==========================================
+ Coverage 61.16% 61.48% +0.32%
==========================================
Files 630 624 -6
Lines 121442 119173 -2269
==========================================
- Hits 74277 73278 -999
+ Misses 47165 45895 -1270 see 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
Ok. I can see the value. I wrote sparse. I think there is some value in installing/distributing only libnrniv. |
To be clear, those libraries are still build statically, so at the end there is still a nrniv blob to deliver. The difference is only on configuration and build. |
✔️ d1c966b -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ db948f1 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ 7a8ba0a -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ 701ccbb -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
701ccbb
to
12aa1ed
Compare
✔️ 12aa1ed -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ f7e5996 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ 8a88b7c -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ 99bd14c -> Azure artifacts URL |
No description provided.