Modernize DECREF in nrnpyerr_str (traceback).

neuronsimulator · Nov 14, 2024 · f8a396f · f8a396f
1 parent e5af1e1
commit f8a396f
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/nrnpython/nrnpy_p2h.cpp b/src/nrnpython/nrnpy_p2h.cpp
@@ -612,24 +612,24 @@ static char* nrnpyerr_str() {
 
         auto type = nb::steal(ptype);
         auto value = nb::steal(pvalue);
+        auto traceback = nb::steal(ptraceback);
 
         // try for full backtrace
         nb::object py_str;
         char* cmes = NULL;
 
         // Since traceback.format_exception returns list of strings, wrap
         // in neuron.format_exception that returns a string.
-        if (!ptraceback) {
-            ptraceback = Py_None;
-            Py_INCREF(ptraceback);
+        if (!traceback) {
+            traceback = nb::none();
         }
         auto pyth_module = nb::steal(PyImport_ImportModule("neuron"));
         if (pyth_module) {
             auto pyth_func = nb::steal(
                 PyObject_GetAttrString(pyth_module.ptr(), "format_exception"));
             if (pyth_func) {
                 py_str = nb::steal(PyObject_CallFunctionObjArgs(
-                    pyth_func.ptr(), type.ptr(), value.ptr(), ptraceback, NULL));
+                    pyth_func.ptr(), type.ptr(), value.ptr(), traceback.ptr(), NULL));
             }
         }
         if (py_str) {
@@ -649,8 +649,6 @@ static char* nrnpyerr_str() {
             Fprintf(stderr, "nrnpyerr_str failed\n");
         }
 
-        Py_XDECREF(ptraceback);
-
         return cmes;
     }
     return NULL;