Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin max Python version to 3.12 on MacOS #74

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Oct 28, 2024

@JCGoran JCGoran marked this pull request as ready for review October 28, 2024 09:01
@JCGoran
Copy link
Collaborator Author

JCGoran commented Oct 28, 2024

Ignore the 8.2.6 failure, we should be using the pre-built wheels from PyPI for that version anyway.

@1uc
Copy link

1uc commented Oct 28, 2024

This is one error I found in the logs:

 Traceback (most recent call last):
  File "/Users/runner/work/nrn-build-ci/nrn-build-ci/nrn/setup.py", line 659, in <module>
    mac_osx_setenv()
  File "/Users/runner/work/nrn-build-ci/nrn-build-ci/nrn/setup.py", line 628, in mac_osx_setenv
    if py_osx_framework is not None and explicit_target > py_osx_framework:
                                        ^^^^^^^^^^^^^^^
UnboundLocalError: cannot access local variable 'explicit_target' where it is not associated with a value

Is it directly related to this PR?

@JCGoran
Copy link
Collaborator Author

JCGoran commented Oct 28, 2024

This is one error I found in the logs:

 Traceback (most recent call last):
  File "/Users/runner/work/nrn-build-ci/nrn-build-ci/nrn/setup.py", line 659, in <module>
    mac_osx_setenv()
  File "/Users/runner/work/nrn-build-ci/nrn-build-ci/nrn/setup.py", line 628, in mac_osx_setenv
    if py_osx_framework is not None and explicit_target > py_osx_framework:
                                        ^^^^^^^^^^^^^^^
UnboundLocalError: cannot access local variable 'explicit_target' where it is not associated with a value

Is it directly related to this PR?

See #74 (comment), we aren't going to make another patch release of NEURON 8.2.x so I don't think it's important.

@nrnhines
Copy link
Member

we aren't going to make another patch release of NEURON 8.2.x so I don't think it's important.

You never know... But can you remind me why Python3.13 can't easily work for NEURON 8.2?

@JCGoran
Copy link
Collaborator Author

JCGoran commented Oct 28, 2024

we aren't going to make another patch release of NEURON 8.2.x so I don't think it's important.

You never know... But can you remind me why Python3.13 can't easily work for NEURON 8.2?

Regarding the release: good point!

Regarding 3.13: I was doing a bunch of testing earlier in neuronsimulator/nrn#3103, and the two issues that arose were:

Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the informative comment #74 (comment)

This will be easy to revert in the future if it becomes desirable. And we can work on the thread-sanitizer issue at that time.

@JCGoran JCGoran merged commit e64a0de into main Oct 30, 2024
19 of 21 checks passed
@JCGoran JCGoran deleted the jelic/fix_macos_failure branch October 30, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants