-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin max Python version to 3.12 on MacOS #74
Conversation
Ignore the 8.2.6 failure, we should be using the pre-built wheels from PyPI for that version anyway. |
This is one error I found in the logs:
Is it directly related to this PR? |
See #74 (comment), we aren't going to make another patch release of NEURON 8.2.x so I don't think it's important. |
You never know... But can you remind me why Python3.13 can't easily work for NEURON 8.2? |
Regarding the release: good point! Regarding 3.13: I was doing a bunch of testing earlier in neuronsimulator/nrn#3103, and the two issues that arose were:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the informative comment #74 (comment)
This will be easy to revert in the future if it becomes desirable. And we can work on the thread-sanitizer issue at that time.
Should fix failures on MacOS 13 such as https://github.com/neuronsimulator/nrn-build-ci/actions/runs/11546453401/job/32134846694