Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SYN COUNT and use epoch milliseconds #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

boverhof
Copy link

modified:   tstat_transport/format.py
-- add SYN COUNT on flow

Joshua Boverhof and others added 2 commits September 28, 2017 13:13
	modified:   tstat_transport/format.py
    -- add SYN COUNT on flow
@boverhof boverhof changed the title Changes to be committed: Add SYN COUNT May 25, 2018
@boverhof boverhof changed the title Add SYN COUNT Add SYN COUNT and use epoch milliseconds May 25, 2018
@apertome
Copy link
Contributor

There are multiple things that use this, and that are expecting the start/end times to be in seconds, not ms; this will break them. Is there a reason you need the output in ms, as opposed to converting after you import?

If you do need ms output, it would be good to add as an optional parameter (but leave seconds the default).

The SYN COUNT part looks fine and shouldn't break anything else.

Thanks,
Michael

@boverhof
Copy link
Author

I had to make some changes to the NERSC DTN tstat elasticsearch data and I noticed in the raw data is in milliseconds. In ES they were showing up as rounded seconds and figured it would be better to have millisecond resolution, and since I have to resend all the TSTAT data anyway I just changed it.

ES by default looks for EPOCH MS so it works easily for NERSC.

Adding a parameter or to the config.ini would be fine.

mostly I just want to use the netsage tstat_transport on NERSC's DTNs, we've been using a fork since October/2017 which is ok.

@apertome
Copy link
Contributor

If you would like to update your branch to add ms as a configurable option, we would be open to that solution. Let me know when you get that added, and I'll review/merge.

@boverhof
Copy link
Author

Okay I'll plan on making 'ms' configurable and notify you when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants