Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port in use #6887

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: port in use #6887

wants to merge 6 commits into from
+43 −22

Conversation

wconrad265
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

This pull request addresses these issues found below

We (@tlane25) outline the problem in the comments in #6840.

This pull request adds better error handling for users who open a port for a serverless function.

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

wconrad265 and others added 2 commits October 18, 2024 15:30
@wconrad265 @tlane25
feat: more clear error messege
4313041 
nforms the user that this could be from a netlify function opening ports

Co-authored-by: Thomas Lane <[email protected]>
@wconrad265 @tlane25
fix: updated port in use error message
6b62b1e 
Co-authored-by: Thomas Lane <[email protected]>
@wconrad265 wconrad265 changed the title Port in use feat: port in use Oct 18, 2024
@wconrad265 wconrad265 marked this pull request as ready for review October 18, 2024 20:48
@wconrad265 wconrad265 requested a review from a team as a code owner October 18, 2024 20:48
DanielSLew
DanielSLew requested changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@DanielSLew DanielSLew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small nit about any types.

src/commands/main.ts Outdated Show resolved Hide resolved
@wconrad265 wconrad265 requested a review from a team as a code owner October 22, 2024 19:48
@wconrad265
Copy link
Contributor Author

This has been updated with a new type.

DanielSLew
DanielSLew reviewed Oct 23, 2024
View reviewed changes
layout.html Outdated Show resolved Hide resolved
src/commands/types.d.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
DanielSLew
DanielSLew previously approved these changes Oct 28, 2024
View reviewed changes
@DanielSLew DanielSLew enabled auto-merge (squash) October 28, 2024 20:16
auto-merge was automatically disabled October 30, 2024 17:52

Head branch was pushed to by a user without write access

@wconrad265
Copy link
Contributor Author

The tests have been fixed. Ready for re-review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlane25 tlane25 tlane25 left review comments

@DanielSLew DanielSLew Awaiting requested review from DanielSLew

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wconrad265 @DanielSLew @tlane25