Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parent/k8sState hostname value #447

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Oct 16, 2024

Fixes: #445

@ilyam8 ilyam8 requested review from a team as code owners October 16, 2024 09:09
@ilyam8
Copy link
Member Author

ilyam8 commented Oct 16, 2024

I'm not sure we need to set deployment.spec.template.spec.hostname as well 🤷‍♂️ Not doing that in this PR.

@ilyam8 ilyam8 merged commit 78f6db3 into netdata:master Oct 22, 2024
2 checks passed
@ilyam8 ilyam8 deleted the feat-add-hostname-value branch October 22, 2024 05:35
@jamesharr
Copy link

I'm not sure we need to set deployment.spec.template.spec.hostname as well 🤷‍♂️ Not doing that in this PR.

I think you made the right call. I'd advise against setting deployment.spec.template.spec.hostname unless a compelling need emerges.

  1. Since you're setting the hostname in the netdata config file, it achieves the desired behavior in Add ability to set hostname for netdata-parent and netdata-k8s-state kubernetes pods #445 and ignores the container's hostname
  2. In my k8s experience, it's exceedingly uncommon to set the container's hostname. Doing so might be confusing when troubleshooting something. When troubleshooting, I typically expect the hostname to be the container's name if I shell in.

Thanks for the quick patch, I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to set hostname for netdata-parent and netdata-k8s-state kubernetes pods
3 participants