add namespace property to all namespaced objects

[rbjorklin]

Using the helm built-in .Release.Namespace as per: https://helm.sh/docs/chart_template_guide/builtin_objects/

[ilyam8]

Hey, @rbjorklin. Thanks for the contribution! But can you please explain why this is needed? Did you have a problem installing the current chart? I see that this topic is somewhat controversial and not really a best practice according to one of helm devs. Also, I don't see it is recommended in Helm Best Practices docs (at least I couldn't find it).

[rbjorklin]

Hey @ilyam8! Thanks for taking the time to dig up those links.
This might boil down to a limitation in our internal tooling but without these changes the chart does not apply correctly. We are currently using an internal fork of the chart with these changes and I was hoping to upstream them.

EDIT: The proposed change should be okay as .Release.Namespace takes on the value provided to helm template --namespace so the end result is the same.

EDIT2: The ClusterRoleBinding already uses .Release.Namespace so if anything this will just ensure consistency in the deployment.

[ilyam8]

I think it is ok to change, the only thing I have in mind (not a k8s specialist) that would break is

• generating with helm (and don't provide --namespace, it will explicitly set the namespace to default)
• pipe the result to kubectl with --namspace != default

e.g.

helm template . | kubectl apply --namespace someNamespace -f -

but I am not sure why someone would want to do it.

[M4itee]

It basically changes nothing in grand scheme of things in terms of functionality. If it helps some people to avoid some kind of problem/bug - let's go.