Skip to content

Commit

Permalink
use 'netdatacli ping' for liveness/readiness probes (#436)
Browse files Browse the repository at this point in the history
  • Loading branch information
ilyam8 authored Aug 26, 2024
1 parent a830481 commit 1c6ef89
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 24 deletions.
16 changes: 8 additions & 8 deletions charts/netdata/templates/child/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -133,20 +133,20 @@ spec:
containerPort: {{ tpl (.Values.child.port | toString) . }}
protocol: TCP
livenessProbe:
httpGet:
host: {{ .Values.child.livenessProbe.httpGet.host }}
path: /api/v1/info
port: http
exec:
command:
- /usr/sbin/netdatacli
- ping
initialDelaySeconds: {{ .Values.child.livenessProbe.initialDelaySeconds }}
failureThreshold: {{ .Values.child.livenessProbe.failureThreshold }}
periodSeconds: {{ .Values.child.livenessProbe.periodSeconds }}
successThreshold: {{ .Values.child.livenessProbe.successThreshold }}
timeoutSeconds: {{ .Values.child.livenessProbe.timeoutSeconds }}
readinessProbe:
httpGet:
host: {{ .Values.child.readinessProbe.httpGet.host }}
path: /api/v1/info
port: http
exec:
command:
- /usr/sbin/netdatacli
- ping
initialDelaySeconds: {{ .Values.child.readinessProbe.initialDelaySeconds }}
failureThreshold: {{ .Values.child.readinessProbe.failureThreshold }}
periodSeconds: {{ .Values.child.readinessProbe.periodSeconds }}
Expand Down
14 changes: 8 additions & 6 deletions charts/netdata/templates/k8s-state/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,18 +92,20 @@ spec:
containerPort: {{ tpl (.Values.k8sState.port | toString) . }}
protocol: TCP
livenessProbe:
httpGet:
path: /api/v1/info
port: http
exec:
command:
- /usr/sbin/netdatacli
- ping
initialDelaySeconds: {{ .Values.k8sState.livenessProbe.initialDelaySeconds }}
failureThreshold: {{ .Values.k8sState.livenessProbe.failureThreshold }}
periodSeconds: {{ .Values.k8sState.livenessProbe.periodSeconds }}
successThreshold: {{ .Values.k8sState.livenessProbe.successThreshold }}
timeoutSeconds: {{ .Values.k8sState.livenessProbe.timeoutSeconds }}
readinessProbe:
httpGet:
path: /api/v1/info
port: http
exec:
command:
- /usr/sbin/netdatacli
- ping
initialDelaySeconds: {{ .Values.k8sState.readinessProbe.initialDelaySeconds }}
failureThreshold: {{ .Values.k8sState.readinessProbe.failureThreshold }}
periodSeconds: {{ .Values.k8sState.readinessProbe.periodSeconds }}
Expand Down
14 changes: 8 additions & 6 deletions charts/netdata/templates/parent/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -96,18 +96,20 @@ spec:
containerPort: {{ .Values.parent.port }}
protocol: TCP
livenessProbe:
httpGet:
path: /api/v1/info
port: http
exec:
command:
- /usr/sbin/netdatacli
- ping
initialDelaySeconds: {{ .Values.parent.livenessProbe.initialDelaySeconds }}
failureThreshold: {{ .Values.parent.livenessProbe.failureThreshold }}
periodSeconds: {{ .Values.parent.livenessProbe.periodSeconds }}
successThreshold: {{ .Values.parent.livenessProbe.successThreshold }}
timeoutSeconds: {{ .Values.parent.livenessProbe.timeoutSeconds }}
readinessProbe:
httpGet:
path: /api/v1/info
port: http
exec:
command:
- /usr/sbin/netdatacli
- ping
initialDelaySeconds: {{ .Values.parent.readinessProbe.initialDelaySeconds }}
failureThreshold: {{ .Values.parent.readinessProbe.failureThreshold }}
periodSeconds: {{ .Values.parent.readinessProbe.periodSeconds }}
Expand Down
4 changes: 0 additions & 4 deletions charts/netdata/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -252,16 +252,12 @@ child:
# memory: 4096Mi

livenessProbe:
httpGet:
host: ""
initialDelaySeconds: 0
failureThreshold: 3
periodSeconds: 30
successThreshold: 1
timeoutSeconds: 1
readinessProbe:
httpGet:
host: ""
initialDelaySeconds: 0
failureThreshold: 3
periodSeconds: 30
Expand Down

0 comments on commit 1c6ef89

Please sign in to comment.