-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EI_clustered_network by Rostami et al to PyNEST examples #3028
Add EI_clustered_network by Rostami et al to PyNEST examples #3028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi thanks for your contribution! I have a few changes requested along with a Pull request made against your branch to add the example to the index page in the docs.
…example Include EI clustered network in examples index for nest-simulator
@schmitfe thanks for the updates, can you fix the conflicts in the CI please? We encourage the developers to set up a pre-commit hook that will check isort/black etc automatically when a commit is made. Take a look at our developer tools for info on that. |
Co-authored-by: Hans Ekkehard Plesser <[email protected]>
@heplesser I was able to change the raster_plot.py to include color groups and think the changes did not introduce any changes to its behavior if no colorgroups are provided. But the change might still need some discussion and refinement. Right now I put it into a new branch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schmitfe Thank you very much for the very thorough revision of the example. It looks good to me now, I just have a few suggestions on details.
@jessica-mitchell Could you take a look as well?
Co-authored-by: Hans Ekkehard Plesser <[email protected]>
Co-authored-by: Hans Ekkehard Plesser <[email protected]>
Co-authored-by: Hans Ekkehard Plesser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @schmitfe ! I have one small change and ask that you resolve the conflict, but otherwise it looks good. The example runs on latest EBRAINS release too.
Co-authored-by: jessica-mitchell <[email protected]>
Thanks for checking. I just corrected the wrong copyright header. Now all the checks should pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schmitfe Thanks a lot, all fine now, just the tests need to go through and we are good to merge.
We added a PyNEST example to simulate an EI-clustered network 1. The example has a similar structure as Potjans_2014 PyNEST example. We provide a short readme and documented source code.
After introduction of the high-level routines to create clustered connectivity, this example might be a good candidate to use them.
Footnotes
Excitatory and inhibitory motor cortical clusters account for balance, variability, and task performance
Vahid Rostami, Thomas Rost, Alexa Riehle, Sacha J. van Albada, Martin P. Nawrot
bioRxiv 2020.02.27.968339; doi: https://doi.org/10.1101/2020.02.27.968339 ↩