FEATURE: Make it possible to validate host, source and target path #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment we can validate only the source path with a regex in the configuration. This change extends the function to be able to also validate the host and target path.
markusguenther
force-pushed
the
feature/use-multiple-validation-options
branch
from
0e126c2
to
bec3032
Compare
Sebobo
reviewed
Oct 9, 2024
| } | ||
|
|
||
| if (!$valid) { | ||
| $this->addFlashMessage('', implode('<br>', $errorMessages), Message::SEVERITY_WARNING); |
There was a problem hiding this comment.
Makes sense to show all errors and not just the first one.
Will test it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, we can validate only the source path with a regex in the configuration. This change extends the function to be able to also validate the host and target path.
Additionally, the PR adds the targetUriPath pattern for the form validation.
As the Javascript side needs another format of regular expressions, we need to configure it at another path.