Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Make RightSideBar inspector resizable #3828

Open
wants to merge 1 commit into
base: 8.4
Choose a base branch
from

Conversation

c4ll-m3-j4ck
Copy link
Contributor

This uses some small html hacks to make RightSideBar resizable in a comparable way to LeftSideBar.

What I did
I added the resize-attribute to RightSideBar and moved the resize-handle to the left edge of the sidebar.

How I did it
Updated Neos.Neos.Ui/packages/neos-ui/src/Containers/RightSideBar/style.module.css

How to verify it
Bildschirmfoto 2024-07-15 um 11 15 17

@github-actions github-actions bot added Feature Label to mark the change as feature 9.0 labels Jul 15, 2024
@Sebobo Sebobo self-requested a review July 24, 2024 11:09
@Sebobo
Copy link
Member

Sebobo commented Jul 24, 2024

We could target this for 8.4 if you like?

@c4ll-m3-j4ck
Copy link
Contributor Author

Sure, why not, I’d still need this for 9.0 as well though, but if we could upmerge afterwards, I’m totally fine with that!

@mhsdesign
Copy link
Member

Yeah we do frequent upmerges so dont worry ;) Also by merging it in 8.4 more people are able to test this ^^

@c4ll-m3-j4ck c4ll-m3-j4ck changed the base branch from 9.0 to 8.4 July 31, 2024 12:57
@github-actions github-actions bot added 8.4 and removed 9.0 labels Jul 31, 2024
@c4ll-m3-j4ck
Copy link
Contributor Author

@Sebobo I've changed the target branch, is there a planned timeframe for the next release?

@mhsdesign
Copy link
Member

Hi as we are "down targeting" a pr the actual changes of you have to be cherry-picked on a fresh 8.4 as otherwise 8.4 will become a full 9.0 after the merge

This uses some small html hacks to make RightSideBar resizable in a comparable way to LeftSideBar.
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i did the git cherrypick magic to target 8.4 ;) When testing i noticed that it doesnt work on safari, but so does the left side bar see bug: #3556 (there is even a possible fix for this ...)

On a chromium based browser the resizing does work though as expected:

Bildschirmaufnahme.2024-08-03.um.13.11.52.mov

But i noticed a small pixel shift, the discard and apply buttons appear to take up more space and the box seems wider and a little off:

before:

image

after:

image

@c4ll-m3-j4ck
Copy link
Contributor Author

Hey @mhsdesign
Thank you for the in-depth review, I'll take a look at whats causing these issues! If there is a fix for the safari issue, maybe I can fix that for the left sidebar as well!

Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me in Chrome the action bar is a few pixels wider with this change due to the direction properties:

CleanShot 2024-09-16 at 10 50 06@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.4 Feature Label to mark the change as feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants