-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Make RightSideBar inspector resizable #3828
base: 8.4
Are you sure you want to change the base?
Conversation
We could target this for 8.4 if you like? |
Sure, why not, I’d still need this for 9.0 as well though, but if we could upmerge afterwards, I’m totally fine with that! |
Yeah we do frequent upmerges so dont worry ;) Also by merging it in 8.4 more people are able to test this ^^ |
@Sebobo I've changed the target branch, is there a planned timeframe for the next release? |
Hi as we are "down targeting" a pr the actual changes of you have to be cherry-picked on a fresh 8.4 as otherwise 8.4 will become a full 9.0 after the merge |
This uses some small html hacks to make RightSideBar resizable in a comparable way to LeftSideBar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So i did the git cherrypick magic to target 8.4 ;) When testing i noticed that it doesnt work on safari, but so does the left side bar see bug: #3556 (there is even a possible fix for this ...)
On a chromium based browser the resizing does work though as expected:
Bildschirmaufnahme.2024-08-03.um.13.11.52.mov
But i noticed a small pixel shift, the discard and apply buttons appear to take up more space and the box seems wider and a little off:
before:
after:
Hey @mhsdesign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This uses some small html hacks to make RightSideBar resizable in a comparable way to LeftSideBar.
What I did
I added the resize-attribute to RightSideBar and moved the resize-handle to the left edge of the sidebar.
How I did it
Updated
Neos.Neos.Ui/packages/neos-ui/src/Containers/RightSideBar/style.module.css
How to verify it