-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!!!FEATURE: Centralize error handling #3792
Open
grebaldi
wants to merge
11
commits into
9.0
Choose a base branch
from
task/centralize-error-handling
base: 9.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a9b33d1
TASK: Convert FlashMessage component to typescript
grebaldi 10068f1
TASK: Convert FlashMessages component to typescript
grebaldi 28f91a3
TASK: Move ErrorView component into ./container/ directory
grebaldi 57af79b
TASK: Move ErrorBoundary component to neos-ui-error package
grebaldi 492f0cd
TASK: Move function `terminateDueToFatalInitializationError` to neos-…
grebaldi 7cd6b2d
TASK: Move component FlashMessages to neos-ui-error package
grebaldi 2538b85
TASK: Add package `@neos-project/framework-observable`
grebaldi 3a9090e
TASK: Add package `@neos-project/framework-observable-react`
grebaldi ff458b6
TASK: Decouple FlashMessage from redux store
grebaldi 2258a0b
!!!TASK: Delete obsolete redux-store elements for flash messages
grebaldi 2caf38a
TASK: Replace all calls to `action.UI.FlashMessages.add` with new `sh…
grebaldi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
# @neos-project/framework-observable-react | ||
|
||
> React bindings for @neos-project/framework-observable | ||
|
||
This package provides a set of React [hooks](https://react.dev/reference/react/hooks) to let components interact with `Observable`s. | ||
|
||
## API | ||
|
||
### `useLatestValueFrom` | ||
|
||
```typescript | ||
// Without default value: | ||
function useLatestValueFrom<V>(observable$: Observable<V>): null | V; | ||
|
||
// With default value: | ||
function useLatestValueFrom<V, D>( | ||
observable$: Observable<V>, | ||
defaultValue: D | ||
): D | V; | ||
``` | ||
|
||
`useLatestValueFrom` is a way to bind a react component the latest value emitted from an `Observable`. | ||
|
||
#### Parameters | ||
|
||
| Name | Description | | ||
| ------------------------- | ---------------------------------------------------------------------------------------------- | | ||
| `observable$` | The `Observable` to subscribe to | | ||
| `defaultValue` (optional) | The value to default for when `observable$` hasn't emitted any values yet (defaults to `null`) | | ||
|
||
#### Return Value | ||
|
||
This hook returns the latest value from the provided `observable$`. If no value has been emitted from the observable yet, it returns `defaultValue` which itself defaults to `null`. | ||
|
||
#### Example | ||
|
||
This component will display the amount of seconds that have passed since it was first mounted: | ||
|
||
```typescript | ||
const clock$ = createObservable((next) => { | ||
let i = 1; | ||
const interval = setInterval(() => { | ||
next(i++); | ||
}, 1000); | ||
|
||
return () => clearInterval(interval); | ||
}); | ||
|
||
const MyComponent = () => { | ||
const seconds = useLatestValueFrom(clock$, 0); | ||
|
||
return <pre>{seconds} seconds passed</pre>; | ||
}; | ||
``` | ||
|
||
You can combine this with `React.useMemo`, if you wish to create an ad-hoc observable: | ||
|
||
```typescript | ||
const MyComponent = (props) => { | ||
const beats = useLatestValueFrom( | ||
React.useMemo( | ||
() => | ||
createObservable((next) => { | ||
let i = 1; | ||
const interval = setInterval(() => { | ||
next(i++); | ||
}, props.millisecondsPerBeat); | ||
|
||
return () => clearInterval(interval); | ||
}), | ||
[props.millisecondsPerBeat] | ||
), | ||
0 | ||
); | ||
|
||
return <pre>{beats} beats passed</pre>; | ||
}; | ||
``` | ||
|
||
### `useLatestState` | ||
|
||
```typescript | ||
function useLatestState<V>(state$: State<V>): V; | ||
``` | ||
|
||
`useLatestState` subscribes to a given state observable and keeps track of its latest value. | ||
|
||
#### Parameters | ||
|
||
| Name | Description | | ||
| -------- | --------------------------------------- | | ||
| `state$` | The `State` observable to keep track of | | ||
|
||
#### Return Value | ||
|
||
This hook returns the latest value from the given `State` observable. Initially it contains the current value of the `State` at the moment the component was first mounted. | ||
|
||
#### Example | ||
|
||
```typescript | ||
const count$ = createState(0); | ||
|
||
const MyComponent = () => { | ||
const count = useLatestState(count$); | ||
const handleInc = React.useCallback(() => { | ||
count$.update((count) => count + 1); | ||
}, []); | ||
const handleDec = React.useCallback(() => { | ||
count$.update((count) => count - 1); | ||
}, []); | ||
|
||
return ( | ||
<div> | ||
<pre>Count {count}</pre> | ||
<button onClick={handleInc}>+</button> | ||
<button onClick={handleDec}>-</button> | ||
</div> | ||
); | ||
}; | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"name": "@neos-project/framework-observable-react", | ||
"version": "", | ||
"description": "React bindings for @neos-project/framework-observable", | ||
"private": true, | ||
"main": "./src/index.ts", | ||
"dependencies": { | ||
"@neos-project/framework-observable": "workspace:*", | ||
"react": "^16.12.0" | ||
}, | ||
"license": "GNU GPLv3" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
/* | ||
* This file is part of the Neos.Neos.Ui package. | ||
* | ||
* (c) Contributors of the Neos Project - www.neos.io | ||
* | ||
* This package is Open Source Software. For the full copyright and license | ||
* information, please view the LICENSE file which was distributed with this | ||
* source code. | ||
*/ | ||
export {useLatestState} from './useLatestState'; | ||
export {useLatestValueFrom} from './useLatestValueFrom'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
/* | ||
* This file is part of the Neos.Neos.Ui package. | ||
* | ||
* (c) Contributors of the Neos Project - www.neos.io | ||
* | ||
* This package is Open Source Software. For the full copyright and license | ||
* information, please view the LICENSE file which was distributed with this | ||
* source code. | ||
*/ | ||
import type {State} from '@neos-project/framework-observable'; | ||
|
||
import {useLatestValueFrom} from './useLatestValueFrom'; | ||
|
||
export function useLatestState<V>(state$: State<V>) { | ||
return useLatestValueFrom(state$, state$.current); | ||
} |
41 changes: 41 additions & 0 deletions
41
packages/framework-observable-react/src/useLatestValueFrom.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
* This file is part of the Neos.Neos.Ui package. | ||
* | ||
* (c) Contributors of the Neos Project - www.neos.io | ||
* | ||
* This package is Open Source Software. For the full copyright and license | ||
* information, please view the LICENSE file which was distributed with this | ||
* source code. | ||
*/ | ||
import React from 'react'; | ||
|
||
import type {Observable} from '@neos-project/framework-observable'; | ||
|
||
export function useLatestValueFrom<V>(observable$: Observable<V>): null | V; | ||
export function useLatestValueFrom<V, D>( | ||
observable$: Observable<V>, | ||
defaultValue: D | ||
): D | V; | ||
|
||
export function useLatestValueFrom<V, D>( | ||
observable$: Observable<V>, | ||
defaultValue?: D | ||
) { | ||
const [value, setValue] = React.useState<null | D | V>( | ||
defaultValue ?? null | ||
); | ||
|
||
React.useEffect(() => { | ||
const subscription = observable$.subscribe({ | ||
next: (incomingValue) => { | ||
if (incomingValue !== value) { | ||
setValue(incomingValue); | ||
} | ||
} | ||
}); | ||
|
||
return () => subscription.unsubscribe(); | ||
}, [observable$]); | ||
|
||
return value; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,152 @@ | ||
# @neos-project/framework-observable | ||
|
||
> Observable pattern implementation for the Neos UI | ||
|
||
> [!NOTE] | ||
> This package implements a pattern for which there is a WICG proposal: | ||
> https://github.com/WICG/observable | ||
> | ||
> It is therefore likely that future versions of this package will use the web-native `Observable` primitive under the hood. | ||
|
||
## API | ||
|
||
### Observables | ||
|
||
An `Observable` represents a sequence of values that can be *observed* from the outside. This is a powerful abstraction that allows to encapsule all kinds of value streams like: | ||
|
||
- (DOM) Events | ||
- Timeouts & Intervals | ||
- Async operations & Promises | ||
- Websockets | ||
- etc. | ||
|
||
An `Observable` can be created using the `createObservable` function like this: | ||
|
||
```typescript | ||
const numbers$ = createObservable((next) => { | ||
next(1); | ||
next(2); | ||
next(3); | ||
}); | ||
``` | ||
|
||
> [!NOTE] | ||
> Suffixing variable names with `$` is a common naming convention to signify that a variable represents an observable. | ||
|
||
Here, the `numbers$` observable represents the sequence of the numbers 1, 2 and 3. This observable can be subscribed to thusly: | ||
|
||
```typescript | ||
numbers$.subscribe((value) => { | ||
console.log(value); | ||
}); | ||
``` | ||
|
||
Because the `numbers$` observable emits its values immediately, the above subscription will immediately log: | ||
``` | ||
1 | ||
2 | ||
3 | ||
``` | ||
|
||
An additional subscription would also immediately receive all 3 values. By default, oberservables are *lazy* and *single-cast*. This means, values are generated exclusively for each subscription, and the generation starts exactly when a subscriber is registered. | ||
|
||
The usefulness of observables becomes more apparent when we introduce some asynchrony: | ||
```typescript | ||
const timedNumbers$ = createObservable((next) => { | ||
let i = 1; | ||
const interval = setInterval(() => { | ||
next(i++); | ||
}, 2000); | ||
|
||
return () => clearInterval(interval); | ||
}); | ||
``` | ||
|
||
This `timedNumbers$` observable will emit a new value every two seconds. This time, the callback used to facilitate the observable returns a function: | ||
```typescript | ||
// .. | ||
return () => clearInterval(interval); | ||
// .. | ||
``` | ||
|
||
This function will be called when a subscription is cancelled. This is a way for observables to clean up after themselves. | ||
|
||
If we now subscribe to `timedNumbers$` like this: | ||
```typescript | ||
const subscription = timedNumbers$.subscribe((value) => { | ||
console.log(value); | ||
}); | ||
``` | ||
|
||
The following values will be logged to the console: | ||
``` | ||
1 (After 2 seconds) | ||
2 (After 4 seconds) | ||
3 (After 6 seconds) | ||
4 (After 8 seconds) | ||
... | ||
``` | ||
|
||
This will go on forever, unless we call the `unsubscribe` on our `subscription` which has been the return value we've saved from `timedNumber$.subscribe(...)`. When we call `unsubscribe`, the cleanup function of the `timedNumbers$` observable will be called and so the interval will be cleared: | ||
```typescript | ||
subscription.unsubscribe(); | ||
``` | ||
|
||
That's all there is to it. With this small set of tools, `Observable`s can be used to encapsule all kinds of synchronous or asynchronous value streams. | ||
|
||
They can be created from a Promise: | ||
```typescript | ||
async function someLongRunningOperation() { | ||
// ... | ||
} | ||
|
||
const fromPromise$ = createObservable((next) => { | ||
someLongRunningOperation().then(next); | ||
}); | ||
``` | ||
|
||
Or DOM events: | ||
```typescript | ||
const clicks$ = createObservable((next) => { | ||
const button = document.querySelector('button'); | ||
button.addEventListener('click', next); | ||
return () => button.removeEventListener('click', next); | ||
}); | ||
``` | ||
|
||
And there are many, many more possibilities. | ||
|
||
### State | ||
|
||
A `State` is a special `Observable` that can track a value over time. `State`s can be created using the `createState` function like this: | ||
|
||
```typescript | ||
const count$ = createState(0); | ||
``` | ||
|
||
The `count$` state is now set to `0`. Unlike regular observables, a `State` instance can be queried for its current value: | ||
```typescript | ||
console.log(count$.current); // output: 0 | ||
``` | ||
|
||
Each `State` instance has an `update` method that can be used to push new values to the state observable. It takes a callback that receives the current value as its first paramater and returns the new value: | ||
|
||
```typescript | ||
count$.update((value) => value + 1); | ||
|
||
console.log(count$.current); // output: 1 | ||
``` | ||
|
||
When a new subscriber is registered to a `State` instance, that subscriber immediately receives the current value: | ||
```typescript | ||
const count$ = createState(0); | ||
count$.update((value) => value + 1); // nothing is logged, nobody has subscribed yet | ||
count$.update((value) => value + 1); // nothing is logged, nobody has subscribed yet | ||
count$.update((value) => value + 1); // nothing is logged, nobody has subscribed yet | ||
|
||
count$.subscribe((value) => console.log(value)); // immediately logs: 3 | ||
|
||
count$.update((value) => value + 1); // logs: 4 | ||
``` | ||
|
||
Unlike regular `Observable`s, `State`s are multi-cast. This means that all subscribers receive updates at the same time, and every subscriber only receives updates that are published after the subscription has been registered. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"name": "@neos-project/framework-observable", | ||
"version": "", | ||
"description": "Observable pattern implementation for the Neos UI", | ||
"private": true, | ||
"main": "./src/index.ts", | ||
"license": "GNU GPLv3" | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for providing extensive documentation for these framework parts.
I think we already partially discussed the idea of the "The Client-side framework" from #3331:
And for the DTO serialisation and de-serialisation (
@neos-project/framework-schema
) you elaborated why it makes sense to provide a custom implementation instead of using a npm library: #3331 (comment)Regarding observers and state handling i remember having talked to you regarding using rx-js vs a custom implementation like
@neos-project/framework-observable
and i think the reasons for a custom implementation were customisability (limited feature scope we only need to implement what we need), smaller bundle size, and thatObservable
will hopefully come to native ECMA script which we definitely want to profit from if available and this can be ensured by having it all under control.But im a little fuzzy on the details and dont quite remember it all. So it would be great to discuss this to fill in the gaps. In the end this adds complexity to our codebase and thus the benefits and downsides should be carefully considered. When we decide for this library an outlined discussion would also help future maintainers to understand our decision ;)
EDIT:
I just skimmed over the implementation and its a super slim layer so +1 from my side ;) And we could consider this dicussion closed ^^ The documentation and tests are more than the code :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've summarized it perfectly :)