Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP FEATURE: Push history on clicking node link node #3749

Draft
wants to merge 1 commit into
base: 8.4
Choose a base branch
from

Conversation

Alvadda
Copy link
Collaborator

@Alvadda Alvadda commented Mar 13, 2024

Resolves: #3241

In the PR: 3440 Nodes in the document tree were converted to a link.

I added that a click on the Node will push the URL change to the browser history object without reloading the page, so that you can navigate back in the document tree via the back functionality from the browser itself.

Clicking on a Node will push the new url to the history.pushState.

How to verify it
Clicking Nodes in the document and then clicking the back button from the browser should navigate you to the last selected Node.

@github-actions github-actions bot added Feature Label to mark the change as feature 8.4 labels Mar 13, 2024
@mhsdesign mhsdesign marked this pull request as draft March 14, 2024 11:08
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to use proper spa routing, see logic in browser saga

@Alvadda Alvadda changed the title FEATURE: Push history on clicking node link node WIP FEATURE: Push history on clicking node link node Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.4 Feature Label to mark the change as feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants