BUGFIX: Prevent rendering of SearchBox #3674
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the displaySearchBox property is false, we should not render the SelectBox that is responsible for the search. Fixes: neos#3673
markusguenther
force-pushed
the
bugfix/3673
branch
from
34627df
to
c229a79
Compare
|
Ok need to check the failing test cases |
|
Shouldn't a default value be set for the |
|
@Sebobo It is disabled but with a multi selectbox, you see the disabled box that takes a lot of space and leads to a bad UX. |
|
The whole concept of the components regarding select boxes is leading to issues, and it seems not that trivial to remove/hide the search box... need to think about it, and therefore it will not make it into the pre-Christmas release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
displaySearchBoxproperty is false, we should not render theSelectBoxthat is responsible for the search.Fixes: #3673