Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gradle module metadata with dependency on Minecraft dependencies Gradle module #10

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

shartte
Copy link
Contributor

@shartte shartte commented May 20, 2024

This change introduces extensive Gradle module metadata to allow a Gradle plugin to depend on NeoForm and the transitive set of Minecraft libraries needed, without having to download NeoForm and parse its config during the Gradle configuration phase (this conflicts with the Gradle configuration cache feature).

@shartte shartte added the 1.20.6 release/1.20.6 label May 20, 2024
@shartte shartte closed this May 20, 2024
@shartte shartte reopened this May 20, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented May 20, 2024

  • Publish PR to GitHub Packages

Last commit published: f729c5871f1a7ed222f9e3dfd2bed709423f2b11.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #10' // https://github.com/neoforged/NeoForm/pull/10
        url 'https://prmaven.neoforged.net/NeoForm/pr10'
        content {
            includeModule('net.neoforged', 'neoform')
        }
    }
}

build.gradle Outdated Show resolved Hide resolved
@shartte shartte marked this pull request as ready for review June 6, 2024 23:44
@shartte
Copy link
Contributor Author

shartte commented Jun 6, 2024

We tested compatibility of this with NG and found no issues.
Since ModDevGradle has been using it for several weeks, I think we're ready to pull the trigger on this.

p.s.: The metadata we use is built automatically using n8n when new Minecraft versions release

@shartte
Copy link
Contributor Author

shartte commented Jun 8, 2024

@coehlrich Do you see any reason not to merge this (and cherry-pick into the 1.21-dev branch?)

@shartte shartte changed the base branch from main to 1.21-dev June 9, 2024 13:04
@coehlrich coehlrich added 1.21-pre4 pre/1.21/1.21-pre4 and removed 1.20.6 release/1.20.6 labels Jun 9, 2024
@coehlrich coehlrich merged commit 1e7ac26 into 1.21-dev Jun 10, 2024
11 checks passed
@shartte shartte deleted the gradle-metadata branch June 10, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21-pre4 pre/1.21/1.21-pre4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants