Skip to content

Commit

Permalink
Warn for Modrinth maven too
Browse files Browse the repository at this point in the history
  • Loading branch information
Matyrobbrt authored and shartte committed Sep 13, 2024
1 parent 3ae11cf commit 5558472
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/main/java/net/neoforged/moddevgradle/tasks/JarJar.java
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ protected void run() throws IOException {
getLogger().warn("Embedding dependency {}:{}:{} from cursemaven using JiJ is likely to cause conflicts at runtime when other mods include the same library from a normal Maven repository.",
includedJar.getGroup(), includedJar.getArtifact(), includedJar.getVersion());
}
// Same with the Modrinth official maven (see https://support.modrinth.com/en/articles/8801191-modrinth-maven)
// While actual versions can be used, version IDs (which are random strings) can also be used
else if ("maven.modrinth".equals(includedJar.getGroup())) {
getLogger().warn("Embedding dependency {}:{}:{} from Modrinth Maven using JiJ is likely to cause conflicts at runtime when other mods include the same library from a normal Maven repository.",
includedJar.getGroup(), includedJar.getArtifact(), includedJar.getVersion());
}

var originalName = includedJar.getFile().getName();
var embeddedName = includedJar.getEmbeddedFilename();
Expand Down

0 comments on commit 5558472

Please sign in to comment.