Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize stub creation #39

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Synchronize stub creation #39

merged 2 commits into from
Aug 16, 2024

Conversation

Matyrobbrt
Copy link
Member

Stubs could crash because of concurrent modification when JST runs in parallel and happens to inject an interface to 2 classes at the same time.
The simplest and most intuitive solution is to synchronize the creation method as there are 3 maps involved, making CHM not the best option.

@Matyrobbrt Matyrobbrt added the bug Something isn't working label Aug 16, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Aug 16, 2024

  • Publish PR to GitHub Packages

Last commit published: 8df07490614503a67a04d31b331fd79d4440ac31.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #39' // https://github.com/neoforged/JavaSourceTransformer/pull/39
        url 'https://prmaven.neoforged.net/JavaSourceTransformer/pr39'
        content {
            includeModule('net.neoforged.jst', 'jst-cli')
            includeModule('net.neoforged.jst', 'jst-cli-bundle')
            includeModule('net.neoforged.jst', 'jst-api')
        }
    }
}

@shartte shartte merged commit 5867da1 into main Aug 16, 2024
1 check passed
@shartte shartte deleted the synchronize-stubs branch August 16, 2024 20:54
@neoforged-releases
Copy link

🚀 This PR has been released as JavaSourceTransformer version 1.0.66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants