Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese translations #19

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Add Chinese translations #19

wants to merge 15 commits into from

Conversation

srcres258
Copy link
Contributor

@srcres258 srcres258 commented Oct 10, 2023

A thorough rewrite of PR #18 according to official instructions of Docusarus mentioned within #18 (comment).


Preview URL: https://pr-19.neoforged-docs-previews.pages.dev

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 10, 2023 05:26 Active
@neoforged-pages-deployments
Copy link

neoforged-pages-deployments bot commented Oct 10, 2023

Deploying with Cloudflare Pages

Name Result
Last commit: 61013502a706341b4d1bcc3ebdef745e31c55df5
Status: ✅ Deploy successful!
Preview URL: https://2c21d0dc.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-19.neoforged-docs-previews.pages.dev

In spite of some abnormal settings with Docusaurus which make the translations
unloaded into the webpage, still add the files and leave the fixing chores
behind to complete.

Signed-off-by: src_resources <[email protected]>
Correct rendering of information blocks of ":::tip", ":::caution" and
":::danger".

Signed-off-by: src_resources <[email protected]>
de4f6dc Update Minecraft Wiki links to new domain after fork (neoforged#12)

Signed-off-by: src_resources <[email protected]>
16dfa80 Rebrand accesstransformers.md (neoforged#3)

Signed-off-by: src_resources <[email protected]>
b9d295f Add explanation for Component and ComponentContents (neoforged#4)

Signed-off-by: src_resources <[email protected]>
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 11, 2023 18:14 Active
srcres258 and others added 5 commits October 12, 2023 18:53
Correct rendering of information blocks of ":::note".

Signed-off-by: src_resources <[email protected]>
Signed-off-by: src_resources <[email protected]>
@ChampionAsh5357
Copy link
Contributor

After discussing translations with some of the other members, we ended up determining we do not have the capacity and the infrastructure to accept translations to other languages. It would be difficult to validate the quality of the PR and keep it maintained without a dedicated team or review process. We have discussed other solutions such as third party links or Crowdin translations, but those have the same issues with validation and infrastructure that we are not yet set up to handle.

We will be revisiting translations in the future once we have more team members that can take off some load from our existing team and some more stable infrastructure, however. So, until then, we will keep this PR open.

Thank you for the contribution, and apologies for the inconvenience.

@IchHabeHunger54 IchHabeHunger54 added the i18n Internationalization. label Jun 12, 2024
@neoforged-automation neoforged-automation bot added the needs rebase This Pull Request needs to be rebased before being merged label Aug 7, 2024
@neoforged-automation
Copy link

@srcres258, this pull request has conflicts, please resolve them for this PR to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Internationalization. needs rebase This Pull Request needs to be rebased before being merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants