AllowOverflow option to avoid checking int range

[Hecate2]

unchecked((int)bigInteger))
Will conflict. Draft for now.

[Hecate2]

Changed the methodology. Skip range checks and throws with compilation option

[Hecate2]

Need a way to compile neo-devpack-dotnet\tests\Neo.Compiler.CSharp.TestContracts\Contract_BigInteger.cs with SimulateOverflow=true

[Hecate2]

Need a way to compile neo-devpack-dotnet\tests\Neo.Compiler.CSharp.TestContracts\Contract_BigInteger.cs with SimulateOverflow=true

Allowed CompilationOptions to be used in tests.
TestGasConsume is set to false.

[Jim8y]

This name is so scary....

[Jim8y]

this can save tons of gas, yes,,,,,, but,,,,,,,

[Jim8y]

rather than allow overflow, i think biginteger only is better

[shargon]

We should not save gas if the security is involved

[shargon]

Sorry miss click

[Hecate2]

We should not save gas if the security is involved

No security problem is involved. This is just handling all int, long, short as BigInteger.

[Hecate2]

rather than allow overflow, i think biginteger only is better

Sometimes it's impossible to write BigInteger everywhere literally in codes. For example, shifting operations (>> and <<) in C# supports only int as the shifted count of bits. Also indexes of arrays have to be int. Then we have to write an explicit coversion (int) which wastes a range check.

[Hecate2]

And our current default settings (with or without my PR) are --checked=false (--allow-overflow=false). This allows silent overflows (from int.MaxValue to int.MinValue, without or without my PR). I think this is even more dangerous. Maybe it's better to have default as --checked=false --allow-overflow=true, or --checked=true --allow-overflow=false

[shargon]

we should detect unchecked keyword

[Hecate2]

we should detect unchecked keyword

We are actually detecting it (with or without this PR). But by default everything is unchecked.

[Jim8y]

rather than allow overflow, i think biginteger only is better

Sometimes it's impossible to write BigInteger everywhere literally in codes. For example, shifting operations (>> and <<) in C# supports only int as the shifted count of bits. Also indexes of arrays have to be int. Then we have to write an explicit coversion (int) which wastes a range check.

excatly, just use what is allowed in biginteger.