-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEP-17 python contract review #10
base: dev
Are you sure you want to change the base?
Conversation
✔️ Deploy Preview for clever-mclean-ad3de1 ready! 🔨 Explore the source changes: 6e7be03 🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-mclean-ad3de1/deploys/62001277c53b8300082f9ed5 😎 Browse the preview: https://deploy-preview-10--clever-mclean-ad3de1.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great update. There are just a few changes that could improve the article in my opinion.
* [Node.js v14.17.0](https://nodejs.org/en/download/) | ||
* [Neo-Express](https://github.com/neo-project/neo-express) | ||
* [Neo3-boa](https://github.com/CityOfZion/neo3-boa/) | ||
* [Neon.js-next](https://github.com/CityOfZion/neon-js/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 32-34 should explicitly call our the version used in the tutorial to ensure that the article remains accurate if we ever push a breaking change to the syntax. This also would allows us to cleanly represent neon.js (although we should probably promote the next branch anyways).
@@ -61,6 +48,15 @@ As can be seen in the native assets contracts linked in the previous section, fu | |||
|
|||
In this section, we'll give a brief overview of the methods we're going to implement later. Right after, we'll showcase the full code of our token. We'll then proceed to cover the code bit by bit throughout the rest of the tutorial. | |||
|
|||
## 4. Testing a Neo smart-contract | |||
|
|||
There are currently 2 ways to test a smart-contract on the Neo platform. Both depend on the [Neo Blockchain Toolkit](https://github.com/neo-project/neo-blockchain-toolkit). We recommend you install it using their VS Code extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not technically
correct and the copy implies that developers must use vscode.
Thanks for updating! |
No description provided.