allow passing X.XX or X.XX.XX as k8s versions #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcmcand
commented
Nov 11, 2024
| @@ -57,7 +57,7 @@ def kubernetes_versions(region: str) -> List[str]: | |||
| credentials, project_id = load_credentials() | |||
| client = container_v1.ClusterManagerClient(credentials=credentials) | |||
| response = client.get_server_config( | |||
| name=f"projects/{project_id}/locations/{region}" | |||
| name=f"projects/{project_id}/locations/{region}", timeout=300 | |||
There was a problem hiding this comment.
I was running into GRPC timeouts using the default 20s context timeout, so I set it to 5 minutes
dcmcand
commented
Nov 11, 2024
| @@ -359,6 +359,7 @@ class GCPNodeGroup(schema.Base): | |||
|
|
|||
|
|
|||
| class GoogleCloudPlatformProvider(schema.Base): | |||
| model_config = ConfigDict(coerce_numbers_to_str=True) | |||
There was a problem hiding this comment.
It was interpreting 1.29 as a float instead of a string, so I had to make it explicitly use a string
viniciusdc
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Fixes #2822
What does this implement/fix?
Allows specifiying either major and minor versions, major minor and patch versions, or full versions of kubernetes for gcp. Also changes guided init so that if no version is specified, the latest patch version is used.
Put a
xin the boxes that applyTesting
How to test this PR?
nebari init --guided-initand don't specify a kubernetes version ornebari init gcp -p your_project_name -d your_domain_name.org1.X,1.X.X, and1.X.X-gke.xAny other comments?