Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 13 upgrade dependencies #2823

Merged
merged 13 commits into from
Nov 6, 2024

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Nov 4, 2024

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Do ci tests pass

Any other comments?

@dcmcand dcmcand changed the base branch from main to python-313-support November 4, 2024 13:24
@dcmcand dcmcand requested a review from aktech November 4, 2024 13:25
@dcmcand dcmcand marked this pull request as ready for review November 5, 2024 13:32
@@ -12,6 +12,7 @@ on:
push:
branches:
- main
- develop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really need this, do we?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, not sure how that got in there

Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dcmcand dcmcand merged commit c352206 into python-313-support Nov 6, 2024
24 of 25 checks passed
@dcmcand dcmcand deleted the python3-13-upgrade-dependencies branch November 6, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants