Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to address paramiko connection errors #2811

Merged
merged 24 commits into from
Nov 14, 2024
Merged

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Oct 31, 2024

Reference Issues or PRs

closes #2777

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

@dcmcand dcmcand marked this pull request as ready for review November 14, 2024 11:58
if b == 0:
print(f"Command '{command}' failed to send")
# Wait for the output to be ready before reading
time.sleep(wait_time)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If output from a command is slow, we can add a wait.

"ls -la ~/..data": "No such file or directory",
}

outputs = run_command_list(commands_contain.keys(), channel, 30)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add a wait for the command output to show up.

@dcmcand dcmcand merged commit 621ea23 into main Nov 14, 2024
25 checks passed
@dcmcand dcmcand deleted the 2777-paramiko-flaky-testing branch November 14, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - Flaky local integration tests failing with paramiko.ssh_exception.AuthenticationException
3 participants