-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tofu binary instead of terraform one #2773
base: main
Are you sure you want to change the base?
Conversation
…/nebari into terraform-to-opentofu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested an upgrade? I think we should test one on an existing deployment just to be sure no issues will arise.
@Adam-D-Lewis I did test an upgrade on GCP and everything went smooth. I still think it would be worthwhile to test both an AWS and Azure upgrade |
Here's a passing local upgrade test: https://github.com/nebari-dev/nebari/actions/runs/11740475035/job/32707098771 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally with clean install and upgrade from 2024.7.1. Does what it says on the tin. 🚀
I'll be testing a couple more scenarios before merging. @Adam-D-Lewis do you think you can test this on an Azure deployment when you have some time? |
I did a fresh deployment and no problems came up |
I deployed 2024.7.1then ran nebari upgrade and deployed and got an error. Here are the logs.
Update: It looks like it was something unrelated to this PR which caused the node groups to be deleted and recreated, redeploying seems to work fine. Ahh, I think it's expected, I just didn't see the warning since the warning will only show up in 2024.11.1 upgrade notes, and I only upgraded to 2024.9.2 in this branch. |
Reference Issues or PRs
Closes #2762
What does this implement/fix?
Put a
x
in the boxes that applyTesting
How to test this PR?
I think there are two important things to test with this PR: (1) deploy from scratch using the OpenTofu binary, and (2) upgrade an existing cluster using the OpenTofu binary. To test:
All resources should be correctly deployed and Nebari should be running as usual after.
Any other comments?
This has been successfully tested in the following scenarios:
2024.9.1
GCP deployment to 8f709da