-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Google Auth and Cloud Python APIs instead of gcloud
CLI
#2083
Merged
Merged
Changes from 4 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0f79dfb
modified the projects and zones function
swastik959 3051574
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 5d593b1
modified whole code
swastik959 53ca190
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 2105e6e
Merge branch 'develop' into swastik
marcelovilla 7d319b5
Fix google dependency versions
marcelovilla 1088d94
Remove unused functions and fix calls to the Google Python APIs
marcelovilla a0694d1
Merge branch 'develop' into swastik
marcelovilla 97677ec
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 6f3d813
Add grpc-google-iam-v1
marcelovilla d6498f9
Merge branch 'swastik' of https://github.com/swastik959/nebari into s…
marcelovilla 4daa377
Load credentials explictly from file and get project ID from environe…
marcelovilla ab7f216
Check if credentials are a file or not before reading them
marcelovilla 4ac3911
Remove gcloud step
marcelovilla 8a47dcd
Add google-auth as an explicit dependency
marcelovilla 7be8fff
Use string ending instead of Path.isfile to check whether env var is …
marcelovilla bdddbe2
Fix dependency version specifier
marcelovilla 6338899
Fix cleanup functions.
marcelovilla 1c2fec3
Add explicit google auth scopes
marcelovilla d54739b
Merge branch 'develop' into swastik
marcelovilla 88785a1
Merge branch 'develop' into swastik
marcelovilla f507f2d
Merge branch 'develop' into swastik
Adam-D-Lewis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function would be useful to do the same thing as AWS and Digital Ocean do and check instance types are valid before deploying. I'd be okay if you just open an issue to re-add that functionality at some point though. Search the repo for
instances(
and see how its used in infrastructure's __init__.py file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Adam-D-Lewis great catch. I just created an issue to track that and make sure we add that functionality for Google Cloud.