Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: enable timeout config in playwright notebook test #1996

Merged
merged 23 commits into from
Oct 13, 2023

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Sep 11, 2023

Reference Issues or PRs

xref #1971 #1958

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

The timeout or (runtime) parameter was not passed to the inner functions, so the playwright test was always using the default value (120 seconds).

@fangchenli fangchenli marked this pull request as ready for review September 11, 2023 17:06
@iameskild
Copy link
Member

Thanks for working on this @fangchenli! I know this test can be flaky at times but I think I would prefer increasing the timeout instead of labeling this as xfail.

@fangchenli fangchenli changed the title TST: xfail flaky playwright test TST: enable timeout config in playwright notebook test Sep 12, 2023
@fangchenli fangchenli added the needs: review 👀 This PR is complete and ready for reviewing label Sep 19, 2023
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fangchenli! Can you update the branch and when CI passes, feel free to merge!

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @fangchenli! I think eventually we want to move these playwright tests to the tests_integration directory so we can retire Cypress . How much trouble would it be to make that update?

@fangchenli ignore that, I think my wires got crossed. This was meant for another PR.

@fangchenli fangchenli merged commit 7b4e8e0 into nebari-dev:develop Oct 13, 2023
9 checks passed
@fangchenli fangchenli deleted the flaky-playwright-test branch October 13, 2023 22:16
@fangchenli
Copy link
Member Author

@iameskild Thanks for reviewing this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants