-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: enable timeout config in playwright notebook test #1996
TST: enable timeout config in playwright notebook test #1996
Conversation
Thanks for working on this @fangchenli! I know this test can be flaky at times but I think I would prefer increasing the timeout instead of labeling this as xfail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fangchenli! Can you update the branch and when CI passes, feel free to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @fangchenli! I think eventually we want to move these playwright tests to the tests_integration
directory so we can retire Cypress . How much trouble would it be to make that update?
@fangchenli ignore that, I think my wires got crossed. This was meant for another PR.
@iameskild Thanks for reviewing this PR! |
Reference Issues or PRs
xref #1971 #1958
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?
The
timeout
or (runtime
) parameter was not passed to the inner functions, so the playwright test was always using the default value (120 seconds).