Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package dependencies #1986

Merged
merged 42 commits into from
Sep 14, 2023
Merged

Update package dependencies #1986

merged 42 commits into from
Sep 14, 2023

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Sep 5, 2023

Reference Issues or PRs

Closes #1985
I also pinned setuptools as a dev dependency to get around #1984

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild added the area: dependencies 📦 All things dependencies label Sep 5, 2023
@iameskild
Copy link
Member Author

Given that we are also looking at upgrading Pydantic, this is blocked by #1928.

@iameskild iameskild added the status: blocked ⛔️ This item is on hold due to another task label Sep 5, 2023
@iameskild iameskild linked an issue Sep 5, 2023 that may be closed by this pull request
@fangchenli
Copy link
Member

Given that we are also looking at upgrading Pydantic, this is blocked by #1928.

We don't have to wait for #1928. For Pydantic, we could bump it to the last v1 version 1.10.12 for now and migrate to v2 after the next release.

@iameskild iameskild removed the status: blocked ⛔️ This item is on hold due to another task label Sep 8, 2023
Base automatically changed from 20230822 to develop September 11, 2023 15:25
@iameskild
Copy link
Member Author

Thanks for reviewing @fangchenli! Unfortunately merging is still blocked. @pavithraes do you mind reviewing when you get a chance? Thank you both :)

@iameskild iameskild self-assigned this Sep 13, 2023
Copy link
Contributor

@sblair-metrostar sblair-metrostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pavithraes
Copy link
Member

Can merge after CI passes :)

pyproject.toml Show resolved Hide resolved
@iameskild iameskild merged commit 55a5323 into develop Sep 14, 2023
25 checks passed
@iameskild iameskild deleted the deps/updates branch September 14, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 All things dependencies
Projects
Development

Successfully merging this pull request may close these issues.

DEPS: Keycloak python client uses deprecated urllib3 module
5 participants