Add Secp256k1 support #1355

gtsonevv · 2024-06-26T06:16:34Z

Pre-flight checklist

I have read the Contributing Guidelines on pull requests.
Commit messages follow the conventional commits spec
If this is a code change: I have written unit tests.
If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Adds support for secp256k1 curve

Test Plan

All tests pass

Related issues/PRs

#985
#1039
#440

changeset-bot · 2024-06-26T06:16:37Z

🦋 Changeset detected

Latest commit: ac393c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages

Name	Type
@near-js/crypto	Minor
@near-js/accounts	Patch
@near-js/biometric-ed25519	Patch
@near-js/keystores	Patch
near-api-js	Patch
@near-js/signers	Patch
@near-js/transactions	Patch
@near-js/wallet-account	Patch
@near-js/keystores-browser	Patch
@near-js/keystores-node	Patch
@near-js/cookbook	Patch
@near-js/providers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gagdiez · 2024-06-26T07:56:07Z

I gave it a quick look, do we have any test against the chain using secp256k1? I think the current tests only look for internal consistency (i.e. what we signed, can be checked) but not necessarily for external consistency (what we signed, the chain can understand)

Making a small transfer after creating the account should be sufficient to prove correctness

andy-haynes

Nice work!

I do think we should reexamine the original approach to avoid introducing unnecessary breaking changes and complexity in serialization, but I'm keen to hear other thoughts. If this does end up being the most desirable approach then at a minimum we should avoid breaking backward compatibility with missing class fields.

packages/biometric-ed25519/src/index.ts

packages/crypto/package.json

packages/crypto/src/public_key.ts

packages/keystores/src/in_memory_key_store.ts

packages/transactions/src/schema.ts

andy-haynes

Thank you for the clarifications on the implementation. Just a couple more things otherwise I think we're good to go 🚀

packages/crypto/src/public_key.ts

packages/transactions/src/signature.ts

andy-haynes · 2024-07-12T17:52:31Z

@race-of-sloths 🦥

race-of-sloths · 2024-07-12T17:53:57Z

@gtsonevv Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Are you going to win race-of-sloths this month? If so, you should speed up! Run, Sloth, run!

Current status: executed

Reviewer	Score
@andy-haynes	5

The average score is 5

@gtsonevv check out your results on the Race of Sloths Leaderboard! and in the profile

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

Tag @race-of-sloths inside your pull requests
Wait for the maintainer to review and score your pull request
Check out your position in the Leaderboard
Keep weekly and monthly streaks to reach higher positions
Boast your contributions with a dynamic picture of your Profile

For maintainers:

Score pull requests that participate in the Race of Sloths
Engage contributors with fair scoring and fast responses so they keep their streaks
Promote the Race to the point where the Race starts promoting you
Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

For contributors
- Include a PR: @race-of-sloths include to enter the Race with your PR
For maintainers:
- Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
- Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
- Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

andy-haynes · 2024-07-12T17:54:58Z

@race-of-sloths score 5

race-of-sloths · 2024-07-12T17:55:55Z

🌟 Score recorded!

@andy-haynes, thank you for scoring this pull request in the Race of Sloths!

andy-haynes

Awesome work! Just noticed two duplicated tests otherwise everything's good to go

andy-haynes · 2024-07-17T20:51:52Z

packages/crypto/test/key_pair.test.js

+ const keyString = 'secp256k1:7s1Jno8tbqFHBMqLh3epaFBbk194zAuMqo8yPbxvTbXn';
+ const keyPair2 = KeyPair.fromString(keyString);
+ expect(keyPair2.toString()).toEqual(keyString);
+ });
 });

 test('test from secret', async () => {


These can be removed now that they're in the describe block above

andy-haynes · 2024-07-19T18:41:31Z

@gtsonevv would you mind rebasing this please? It should just be your work + release ahead of you in history.

gtsonevv · 2024-07-22T10:56:35Z

@andy-haynes rebase onto master?

race-of-sloths · 2024-07-23T21:34:15Z

✅ PR is finalized!

Your contribution is much appreciated with a final score of 5!
You have received 50 Sloth points for this contribution

gtsonevv and others added 18 commits May 7, 2024 13:04

feat: add support for secp256k1

cc5a11b

fix: fix linter errors

828c84b

fix: use enum for public key data

196291f

fix: add schema changes

2cc98d9

fix: remove enums from schema

7b178a1

fix: lint

5ffc704

fix: update PublicKey

2bd94f9

chore: fix linter errors

ad024f1

Merge branch 'master' into add-secp256k1-support

15d00f3

Merge branch 'add-secp256k1-support' into secp256k1-support-new

a9051d7

fix: revert enum changes

a559b29

fix: fix linter errors

4f12396

fix: public key schema

67eb34d

fix: update signature class and schema

3991ef1

fix: fix linter errors

c16caaa

fix: fix a secp256k1 test

c567804

fix: fix linter errors

9aa9446

fix: fix publickey method

9c3b8eb

gtsonevv requested a review from vikinatora June 26, 2024 06:16

chore: add a changeset file

7d5a824

gtsonevv added 3 commits July 3, 2024 11:02

chore: lock secp256k1 dependency version

effe3d4

test: add a secp156k1 send money test

fc951f3

fix: update pnpm/action-setup to v4

518c361

gtsonevv requested review from morgsmccauley and andy-haynes as code owners July 10, 2024 06:34

Merge branch 'master' into secp256k1-support-new

b79dbe5

vikinatora previously approved these changes Jul 11, 2024

View reviewed changes

andy-haynes requested changes Jul 12, 2024

View reviewed changes

fix: fix @near-js/crypto/lib/key_pair imports

7ce5bda

gtsonevv dismissed vikinatora’s stale review via 7ce5bda July 12, 2024 12:59

refactor: remove duplicated Enum

2af0435

andy-haynes requested changes Jul 12, 2024

View reviewed changes

gtsonevv added 2 commits July 15, 2024 15:49

refactor: add getter to PublicKey and Signature classes

65714fb

Merge branch 'master' into secp256k1-support-new

365fa88

gtsonevv requested review from andy-haynes and vikinatora July 15, 2024 13:03

Merge branch 'master' into secp256k1-support-new

a85175b

andy-haynes previously approved these changes Jul 17, 2024

View reviewed changes

chore: remove duplicated test

8c4aa1f

gtsonevv dismissed andy-haynes’s stale review via 8c4aa1f July 22, 2024 09:43

Merge branch 'master' into secp256k1-support-new

ac393c7

andy-haynes approved these changes Jul 22, 2024

View reviewed changes

andy-haynes merged commit cc93136 into near:master Jul 22, 2024
1 check passed

This was referenced Jul 22, 2024

Publish packages #1365

Merged

Publish packages LimeChain/near-api-js#13

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Secp256k1 support #1355

Add Secp256k1 support #1355

gtsonevv commented Jun 26, 2024 •

edited

Loading

changeset-bot bot commented Jun 26, 2024 •

edited

Loading

gagdiez commented Jun 26, 2024

andy-haynes left a comment

andy-haynes left a comment

andy-haynes commented Jul 12, 2024

race-of-sloths commented Jul 12, 2024 •

edited

Loading

andy-haynes commented Jul 12, 2024

race-of-sloths commented Jul 12, 2024

andy-haynes left a comment

andy-haynes Jul 17, 2024

andy-haynes commented Jul 19, 2024

gtsonevv commented Jul 22, 2024

race-of-sloths commented Jul 23, 2024

Add Secp256k1 support #1355

Add Secp256k1 support #1355

Conversation

gtsonevv commented Jun 26, 2024 • edited Loading

Pre-flight checklist

Motivation

Test Plan

Related issues/PRs

changeset-bot bot commented Jun 26, 2024 • edited Loading

🦋 Changeset detected

gagdiez commented Jun 26, 2024

andy-haynes left a comment

Choose a reason for hiding this comment

andy-haynes left a comment

Choose a reason for hiding this comment

andy-haynes commented Jul 12, 2024

race-of-sloths commented Jul 12, 2024 • edited Loading

andy-haynes commented Jul 12, 2024

race-of-sloths commented Jul 12, 2024

🌟 Score recorded!

andy-haynes left a comment

Choose a reason for hiding this comment

andy-haynes Jul 17, 2024

Choose a reason for hiding this comment

andy-haynes commented Jul 19, 2024

gtsonevv commented Jul 22, 2024

race-of-sloths commented Jul 23, 2024

✅ PR is finalized!

gtsonevv commented Jun 26, 2024 •

edited

Loading

changeset-bot bot commented Jun 26, 2024 •

edited

Loading

race-of-sloths commented Jul 12, 2024 •

edited

Loading