Store pre-signatures using Redis

[volovyks]

This is the setup of Docker in the same container. Some people consider it a bad practice, but it may be a simpler solution for node validators. I have no strong opinion here.

It is expected to be executed with

docker run -d \
  --name my-redis-rust-app \
  -v /path/on/host/redis-data:/var/lib/redis \
  -p 6379:6379 \
  -p 8080:8080 \
  my-redis-rust-app

It will persist the apend file on the VM.

cc @kmaus-near @ppca

[ppca]

@kmaus-near How does your draft redis setup work? Is it different or similar to this?

[kmaus-near]

@kmaus-near How does your draft redis setup work? Is it different or similar to this?

My homelab setup uses a dedicated VM running a Redis container vs. baking it into the multichain image, but other than that similar configuration. @volovyks and myself discussed this a bit yesterday, it's not exactly the "best practice" but if we are trying to simplify this for our partners, this may be a better route. Plus if we are to run it locally, we are then going to be running 3 containers on a single VM if we do not bake it into the image itself, which is not ideal resource wise or best practice wise. In short, both are not ideal, but for different reasons 😂.

I would suggest that we try to keep the code interacting with Redis as decoupled as possible, so if in the future we need to separate Redis from the base image, we can do so easily.

[volovyks]

@kmaus-near all we need in code is the Redis URL, so it is not coupled. If we change how we manage Redis storage, most of the complexity will be on the Terraform side.

[ppca]

presignature storage logic mostly look good to me.

[ChaoticTempest]

hmm, how come we didn't need to expose the node's port before

[kmaus-near]

Also wondering why 8080 is now exposed. Port is set at 3000 for the mpc-node service by terraform. we will need to expose 6379 though for redis.

[ChaoticTempest]

hmm, generate is basically start protocol though. I would rather we keep it as what we had before, because we also have the generate function

[volovyks]

Renamed to get_or_start_generation.
When you call presignature_manager.get_or_generate you are expecting a presignature, not a protocol.

[ChaoticTempest]

hmm, that's not right either though. get_or_generate never returned us the presignature, it always returned us the protocol

[kmaus-near]

I needed this /data directory to be owned by redis, so it can store data.

[kmaus-near]

I needed to add the rest of the config. I have changed the AOF parameters as well as using the /data directory inside the container for persistence.

[kmaus-near]

had to change this from /etc to /var. In container optimized OS, /etc is a stateless directory and ships with a default configuration. /var is persistent and gets mounted to /mnt/stateful-partition