Payments with balance #768
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagdiez
reviewed
Jul 31, 2024
| // withdraw the signature fee | ||
| mpc_contract | ||
| .balances | ||
| .withdraw(&request.account_id, request.signature_fee); |
There was a problem hiding this comment.
@volovyks the recommended pattern for handling balances is:
- withdraw on request
- refund on error
Otherwise, you could get a lot of requests, which you approve since the user has the balance, and then discover during the response that the user actually has no money to pay for them all
So in this case, we would want to use balances.withdraw on sign, and return_signature would refund the user if they never got the signature because of a response timeout
There was a problem hiding this comment.
That is true. We can fail in multiple places, so this design seemed simpler and more robust.
There was a problem hiding this comment.
I will come back to it if we will choose this direction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.