Warn on HSE mis-parse #375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #362, albeit a bit rough.
Before this fix, if you ran
hoogle generate --local=.on the hoogle repo you would get an errorhseToItem failed, from trying and failing to parse theCHANGES.txtfile. After this change, you will get that same message in the.warnfile, but Hoogle will happily generate the rest of the database.I will readily admit this is an inelegant fix. If a stray
.txtfile in the directory being scanned contains valid haskell on any line it will be slurped up by HSE. I think this is an acceptable tradeoff, considering the alternative is that every.txtfile must contain valid HSE-parsable haskell on every line, otherwise Hoogle will not generate a database.