-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add regex validation rule to filename attributes #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brynnz22! Looks like we managed to drag some extra quotes in that we will want to fix so that only lines 8 and 132 have changes in. If we do want to standardise quoting descriptions (and that might be a good idea we can do this through a different issue/PR.
I'm going to hold off on approving and merging for now and will try and deploy this branch into a testing instance
Delete leading and trailing white spaces in filename and scDNA-seq Level 1 descriptions.
Delete extra quotes and spaces.
Delete quotes and leading and trailing white spaces, including "url"
Delete leading and trailing quotes/white spaces for is lowest level
@adamjtaylor I implemented all the fixes. It should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks @brynnz22. This looks good. I will redeploy to testing before we merge here. |
I'm struggling to get this to deploy currently as the develop schematic does not install properly. |
@adamjtaylor there was an update to schematic yesterday that made it incompatible with python 3.8, which our deployment workflow uses. I'm working to update the deployment to use python 3.10 in this branch and I'll let you know when testing is complete. |
Hold on this until next data model release |
This successfully converts to a json.ld using the Schematic CLI (schematicpy 23.1.1). |
I tried validating a manifest using the CLI and I'm not sure what is going on. It doesn't seem to recognize the entire Filename column as it returns a |
I can test this out more when I am back on the 21st. |
Removing from the project board as is tracked in the linked issue #139 |
PR cannot be merged due to key error. Re-review once #139 unbocked
Added the validation rule:
regex search ^\S*$
toFilename
andChannel Metadata Filename
attributes. I was not sure about adding it to the'Channel Metadata Filename
attribute, so I can delete this if needed. Addressing issue #139