Add title option to feed generation
#13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbr23
requested changes
Jun 19, 2022
|
|
||
| image_tag = "" | ||
|
|
||
| if sub['image'] is not None: |
There was a problem hiding this comment.
this will KeyError if the image key doesn't work, can you switch to sub.get('image') ?
| %s | ||
| <link href="%s" /> | ||
| """ % (datetime.datetime.now(), | ||
| sub['title'] or sub['name'], |
There was a problem hiding this comment.
need to use sub.get('title') here too, to avoid KeyError if the user has not defined a title.
| image_tag = "" | ||
|
|
||
| if sub['image'] is not None: | ||
| image_url = "/".join([sub["url_root"], sub["name"], sub["image"]]) |
There was a problem hiding this comment.
We need to fetch this image at some point right? Am I missing something?
Comment on lines
+251
to
+256
| for t in items: | ||
| if t[1] not in unique_ids or unique_ids[t[1]]['timestamp'] < t[0]: | ||
| unique_ids[t[1]] = { "timestamp": t[0], "xml": t[2] } | ||
|
|
||
| for i in unique_ids: | ||
| xml += unique_ids[i]['xml'] |
There was a problem hiding this comment.
Can you explain what issue you're solving here?
nbr23
force-pushed
the
master
branch
2 times, most recently
from
75edd85
to
45cba06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.