Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include data alongside errors for a service's partial success #213

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Include data alongside errors for a service's partial success #213

merged 6 commits into from
Aug 20, 2024

Conversation

JohnStarich
Copy link
Member

@JohnStarich JohnStarich commented Aug 20, 2024 •
edited
Loading

  • Bump nautilus/graphql to pick up partial success changes
  • Add failing test for partial success with one service
  • Fix test
    • Remove unused field
    • Extract channel sending from execution of a single step
    • Extract wait group handling from single step execution
    • Remove impossible condition with nil result

Fixes #212

@JohnStarich JohnStarich marked this pull request as ready for review August 20, 2024 06:00
@JohnStarich JohnStarich merged commit 6496791 into master Aug 20, 2024
6 checks passed
@JohnStarich JohnStarich deleted the wip/debug-missing-data-with-errors branch August 20, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Partial success (data + errors) from one service only returns errors
1 participant
@JohnStarich