Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize local dev and CI #13

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Stabilize local dev and CI #13

merged 2 commits into from
Aug 20, 2024

Conversation

naushadh
Copy link
Owner

see commit messages to learn more

This reverts commit c8f4f43.

The [guide](https://dvc.ai/blog/testing-external-contributions-using-github-actions-secrets) we followed is no longer functional with current Github actions and always yields a cryptic error: "The job could not retrieve the repository token."
- Update Makefile to invoke `docker compose` instead of `docker-compose` since the latter was deprecated in latest version of docker; see [article](https://docs.docker.com/compose/migrate/)
- Update docker-compose.yml to drop version field since it is deprecated in latest version of docker compose; see [forum](https://forums.docker.com/t/docker-compose-yml-version-is-obsolete/141313)
- Update README.md to document version and build steps required for local development
- Update release.yml to assert successful state since completed doesn't imply that, see [comment](https://github.com/orgs/community/discussions/26238#discussioncomment-3250901).
- Update test.yml to upgrade checkout action
@naushadh naushadh mentioned this pull request Aug 20, 2024
@naushadh naushadh merged commit 18e8816 into main Aug 20, 2024
2 of 3 checks passed
@naushadh naushadh deleted the stabilize branch August 20, 2024 00:41
@naushadh
Copy link
Owner Author

Confirmed release workflow was skipped when test workflow failed

Screenshot 2024-08-19 at 5 48 15 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant