Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report observer status in cluster replicas for streams and consumers #877

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neilalexander
Copy link
Member

This is to support nats-io/nats-server#4582.

Signed-off-by: Neil Twigg [email protected]

@neilalexander
Copy link
Member Author

Dependent on nats.go and jsm.go PRs before the replace directives can be removed and this can be merged.

Copy link
Collaborator

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment about replace

@@ -2,9 +2,14 @@ module github.com/nats-io/natscli

go 1.20

replace github.com/nats-io/jsm.go => github.com/nats-io/jsm.go v0.1.1-0.20230926090317-6fb84b8ef01d
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not have these and instead update the dependency to point to the commit.

I keep forgetting about these and then do a release with them in which then end up failing go install installation method - happened when I did 0.1.0 and then had to do 0.1.1.

So hoping to avoid this mistake all together if I can :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, these will be removed as commented above but for now it's just so that CI does the right thing while in draft state.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, I missed the comment you left there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants