Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker/build-push-action for Linux builds #183

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

neilalexander
Copy link
Member

Adds build provenance etc.

Currently doesn't modify Windows builds as BuildKit still doesn't seem to be properly supported on Windows runners.

Signed-off-by: Neil Twigg [email protected]

Adds provenance etc.

Signed-off-by: Neil Twigg <[email protected]>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but did not look in great detail..

This been tested externally hopefully.

@derekcollison derekcollison merged commit 95b80b9 into main Sep 12, 2024
10 checks passed
@neilalexander
Copy link
Member Author

Yes tested it on a forked repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants